acme: Fix loading credentials
authorAdrien DAURIAT <[email protected]>
Wed, 30 Jan 2019 22:32:51 +0000 (23:32 +0100)
committerToke Høiland-Jørgensen <[email protected]>
Fri, 8 Feb 2019 16:17:13 +0000 (17:17 +0100)
Move loading credential function before cert renewal call as credentials might be needed for some renewal operations ( ex: DNS )

Signed-off-by: Adrien DAURIAT <[email protected]>
[[email protected]: Port to master branch]
Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
net/acme/files/run.sh

index b5dfc731ddd29e561d731ed379e744f1fe3e8eb1..b0cae8fa6493b92440a583b6ea65ee7b148ca2c3 100644 (file)
@@ -204,6 +204,12 @@ issue_cert()
     [ -n "$webroot" ] || [ -n "$dns" ] || pre_checks "$main_domain" || return 1
 
     log "Running ACME for $main_domain"
+    
+    handle_credentials() {
+        local credential="$1"
+        eval export $credential
+    }
+    config_list_foreach "$section" credentials handle_credentials
 
     if [ -e "$STATE_DIR/$main_domain" ]; then
         if [ "$use_staging" -eq "0" ] && is_staging "$main_domain"; then
@@ -240,12 +246,6 @@ issue_cert()
         acme_args="$acme_args --webroot $webroot"
     fi
 
-    handle_credentials() {
-        local credential="$1"
-        eval export $credential
-    }
-    config_list_foreach "$section" credentials handle_credentials
-
     if ! $ACME --home "$STATE_DIR" --issue $acme_args; then
         failed_dir="$STATE_DIR/${main_domain}.failed-$(date +%s)"
         err "Issuing cert for $main_domain failed. Moving state to $failed_dir"